Improve testing for SDCH.

net/base/sdch_manager.h

Index: net/base/sdch_manager.h
diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h
index 6f2ea5af6de0a637e70a395164fe5f80fdd09af3..da3b7d723a442ca25d800e7b8f0cbb88b6dcd3a6 100644
--- a/net/base/sdch_manager.h
+++ b/net/base/sdch_manager.h
@@ -246,7 +246,7 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
   static void SdchErrorRecovery(ProblemCodes problem);
 
   // Register a fetcher that this class can use to obtain dictionaries.
-  void set_sdch_fetcher(SdchFetcher* fetcher);
+  void set_sdch_fetcher(scoped_ptr<SdchFetcher> fetcher);
 
   // Enables or disables SDCH compression.
   static void EnableSdchSupport(bool enabled);
@@ -336,6 +336,10 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
 
   void SetAllowLatencyExperiment(const GURL& url, bool enable);
 
+  int GetFetchesCountForTesting() const {

[jar (doing other things), 2014/08/13 01:28:59]

nit: FWIW: This is a place where hacker style would be common:
get_fetches_count_for_testing()

[Randy Smith (Not in Mondays), 2014/08/13 02:05:26]

Agreed; I just know there is automated scanning and verification of
*ForTesting() routines, and I don't know that that's also done for
*_for_testing() routines.  Want me to switch anyway?

+    return fetches_count_for_testing_;
+  }
+
  private:
   typedef std::map<std::string, int> DomainCounter;
   typedef std::set<std::string> ExperimentSet;
@@ -370,6 +374,8 @@ class NET_EXPORT SdchManager : public NON_EXPORTED_BASE(base::NonThreadSafe) {
   // round trip test has recently passed).
   ExperimentSet allow_latency_experiment_;
 
+  int fetches_count_for_testing_;
+
   DISALLOW_COPY_AND_ASSIGN(SdchManager);
 };