Improve testing for SDCH.

sdch/sdch.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 11 matching lines @@
         'open-vcdiff/src/checksum.h',
         'open-vcdiff/src/codetable.cc',
         'open-vcdiff/src/codetable.h',
         'open-vcdiff/src/compile_assert.h',
         'open-vcdiff/src/decodetable.cc',
         'open-vcdiff/src/decodetable.h',
         'open-vcdiff/src/encodetable.cc',
         'open-vcdiff/src/encodetable.h',
         'open-vcdiff/src/google/output_string.h',
         'open-vcdiff/src/google/vcdecoder.h',
+        'open-vcdiff/src/google/vcencoder.h',
         'open-vcdiff/src/headerparser.cc',
         'open-vcdiff/src/headerparser.h',
         'open-vcdiff/src/instruction_map.cc',
         'open-vcdiff/src/instruction_map.h',
+        'open-vcdiff/src/jsonwriter.h',

[jar (doing other things), 2014/07/31 23:19:23]

I didn't think to read this carefully.... but since you asked about my thought
on the "sdch" directory... and this is the only such entry...

Why are we using their jsonwriter?  Don't we have such functionality in
Chromium?  

take a look in base/json/*

base/json/json_writer.cc for example.

[Randy Smith (Not in Mondays), 2014/08/11 20:33:25]

To be explicit, the things I need sdch/OWNERS review on are this change and the
inclusion of it in chrome/browser/net/DEPS.
The issue is that, in adding the vcencoder.cc file, I ended up with a undefined
symbol which was to the jsonwriter.  I'm very reluctant to try and hook the
vcencoder.cc file up to our jsonwriter if it was written in parallel with and to
depend on the SDCH jsonwriter file.

+        'open-vcdiff/src/jsonwriter.cc',
         'open-vcdiff/src/rolling_hash.h',
         'open-vcdiff/src/testing.h',
         'open-vcdiff/src/varint_bigendian.cc',
         'open-vcdiff/src/varint_bigendian.h',
         'open-vcdiff/src/vcdecoder.cc',
+        'open-vcdiff/src/vcencoder.cc',
         'open-vcdiff/src/vcdiff_defs.h',
         'open-vcdiff/src/vcdiffengine.cc',
         'open-vcdiff/src/vcdiffengine.h',
         'open-vcdiff/vsprojects/config.h',
         'open-vcdiff/vsprojects/stdint.h',
       ],
       'include_dirs': [
         'open-vcdiff/src',
       ],
       'direct_dependent_settings': {
@@ skipping 40 matching lines @@
         }
       },
       'cflags': [
         '-include', '<(logging_dir)/sdch/<(logging_path)',
         # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11:
         '-Wno-deprecated-declarations',
       ],
     },
   ],
 }