Improve testing for SDCH.

net/http/http_transaction_test_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_TRANSACTION_UNITTEST_H_
 #define NET_HTTP_HTTP_TRANSACTION_UNITTEST_H_
 
 #include "net/http/http_transaction.h"
 
 #include <string>
@@ skipping 10 matching lines @@
 #include "net/base/test_completion_callback.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 
 namespace net {
 class HttpRequestHeaders;
 class IOBuffer;
+struct HttpRequestInfo;
 }
 
 //-----------------------------------------------------------------------------
 // mock transaction data
 
 // these flags may be combined to form the test_mode field
 enum {
   TEST_MODE_NORMAL = 0,
   TEST_MODE_SYNC_NET_START = 1 << 0,
   TEST_MODE_SYNC_NET_READ  = 1 << 1,
@@ skipping 179 matching lines @@
 
   virtual void SetBeforeProxyHeadersSentCallback(
       const BeforeProxyHeadersSentCallback& callback) OVERRIDE;
 
   virtual int ResumeNetworkStart() OVERRIDE;
 
   CreateHelper* websocket_handshake_stream_create_helper() {
     return websocket_handshake_stream_create_helper_;
   }
   net::RequestPriority priority() const { return priority_; }
+  const net::HttpRequestInfo* http_request_info() const {

[mef, 2014/07/23 18:34:30]

nit: nl above, maybe name it |request()| to match variable name.

[Randy Smith (Not in Mondays), 2014/07/29 23:44:22]

The nl doesn't fit to my eye with the relationship of the two methods above--I
take this as "simple accessors are clustered together without newlines
separating them", but if you feel strongly I'll change it.  I've changed the
name.

[mef, 2014/07/30 17:14:58]

Acknowledged.

+    return request_;
+  }
 
  private:
   int StartInternal(const net::HttpRequestInfo* request,
                     const net::CompletionCallback& callback,
                     const net::BoundNetLog& net_log);
   void CallbackLater(const net::CompletionCallback& callback, int result);
   void RunCallback(const net::CompletionCallback& callback, int result);
 
   base::WeakPtrFactory<MockNetworkTransaction> weak_factory_;
   const net::HttpRequestInfo* request_;
@@ skipping 60 matching lines @@
   base::WeakPtr<MockNetworkTransaction> last_transaction_;
 };
 
 //-----------------------------------------------------------------------------
 // helpers
 
 // read the transaction completely
 int ReadTransaction(net::HttpTransaction* trans, std::string* result);
 
 #endif  // NET_HTTP_HTTP_TRANSACTION_UNITTEST_H_