Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: media/formats/mp4/avc.h

Issue 379983002: Fix AnnexB validation logic to work with encrypted content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address CR comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/h264_parser.cc ('k') | media/formats/mp4/avc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/avc.h
diff --git a/media/formats/mp4/avc.h b/media/formats/mp4/avc.h
index 0d84eef9c8c94d6903add268b78952dc85c23214..1740b8fc92c7c7a2ac4a560b3827d31a770d7b6d 100644
--- a/media/formats/mp4/avc.h
+++ b/media/formats/mp4/avc.h
@@ -39,11 +39,15 @@ class MEDIA_EXPORT AVC {
// Verifies that the contents of |buffer| conform to
// Section 7.4.1.2.3 of ISO/IEC 14496-10.
+ // |subsamples| contains the information about what parts of the buffer are
+ // encrypted and which parts are clear.
// Returns true if |buffer| contains conformant Annex B data
// TODO(acolwell): Remove the std::vector version when we can use,
// C++11's std::vector<T>::data() method.
- static bool IsValidAnnexB(const std::vector<uint8>& buffer);
- static bool IsValidAnnexB(const uint8* buffer, size_t size);
+ static bool IsValidAnnexB(const std::vector<uint8>& buffer,
+ const std::vector<SubsampleEntry>& subsamples);
+ static bool IsValidAnnexB(const uint8* buffer, size_t size,
+ const std::vector<SubsampleEntry>& subsamples);
};
} // namespace mp4
« no previous file with comments | « media/filters/h264_parser.cc ('k') | media/formats/mp4/avc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698