Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: media/formats/mp4/mp4_stream_parser.cc

Issue 379983002: Fix AnnexB validation logic to work with encrypted content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change method name and fix crash Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/h264_parser.cc ('K') | « media/formats/mp4/avc_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/mp4_stream_parser.cc
diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc
index 0eb15d9f2ce09c64f5f332438c46c136f2c554ed..4c8d6574518adaebb82d7e734c2fdfbb95641511 100644
--- a/media/formats/mp4/mp4_stream_parser.cc
+++ b/media/formats/mp4/mp4_stream_parser.cc
@@ -382,8 +382,7 @@ bool MP4StreamParser::PrepareAVCBuffer(
RCHECK(AVC::InsertParamSetsAnnexB(avc_config, frame_buf, subsamples));
}
- // TODO(acolwell): Improve IsValidAnnexB() so it can handle encrypted content.
- DCHECK(runs_->is_encrypted() || AVC::IsValidAnnexB(*frame_buf));
+ DCHECK(AVC::IsValidAnnexB(*frame_buf, *subsamples));
return true;
}
« media/filters/h264_parser.cc ('K') | « media/formats/mp4/avc_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698