Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 379973003: Remove comparison of address with NULL. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove comparison of address with NULL. Addresses are always non-NULL per spec. This merges a change that has already been applied to the google-internal version of protobuf. BUG=381910 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/protobuf/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
6 years, 5 months ago (2014-07-10 00:35:24 UTC) #1
Reid Kleckner
lgtm This is so we can roll clang on non-Windows platforms, right?
6 years, 5 months ago (2014-07-10 00:39:20 UTC) #2
Nico
On 2014/07/10 00:39:20, Reid Kleckner wrote: > lgtm > > This is so we can ...
6 years, 5 months ago (2014-07-10 00:41:41 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 01:02:02 UTC) #4
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 01:03:02 UTC) #5
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 01:03:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/379973003/1
6 years, 5 months ago (2014-07-10 01:04:02 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 05:17:43 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:06:22 UTC) #9
Message was sent while issue was closed.
Change committed as 282282

Powered by Google App Engine
This is Rietveld 408576698