Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 379923010: [PPAPI] Make the NaCl SDK presubmit check a warning instead of an error. (Closed)

Created:
6 years, 5 months ago by binji
Modified:
6 years, 5 months ago
Reviewers:
teravest
CC:
chromium-reviews, Peter Kasting
Project:
chromium
Visibility:
Public.

Description

[PPAPI] Make the NaCl SDK presubmit check a warning instead of an error. There are some PPAPI dev interfaces that should not be added to the SDK, so it is better to warn instead of making it a presubmit error. BUG=none R=teravest@chromium.org TEST=made change to ppapi/cpp/buffer_dev.h, ran git cl presubmit

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M ppapi/PRESUBMIT.py View 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
binji
6 years, 5 months ago (2014-07-09 20:53:17 UTC) #1
teravest
lgtm
6 years, 5 months ago (2014-07-09 20:55:38 UTC) #2
binji
The CQ bit was checked by binji@chromium.org
6 years, 5 months ago (2014-07-09 20:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/379923010/1
6 years, 5 months ago (2014-07-09 20:59:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 00:35:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 02:58:40 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 02:58:41 UTC) #7
Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

Powered by Google App Engine
This is Rietveld 408576698