Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 379923008: Correctly compute host_arch in breakpad_tools.gypi (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correctly compute host_arch in breakpad_tools.gypi BUG=360311 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282100

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M breakpad/breakpad_tools.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Needed to build minidump_stackwalk on 32bit with a 64bit kernel. (Do you know why this ...
6 years, 5 months ago (2014-07-09 19:33:55 UTC) #1
Lei Zhang
On 2014/07/09 19:33:55, Nico (away) wrote: > Needed to build minidump_stackwalk on 32bit with a ...
6 years, 5 months ago (2014-07-09 19:41:33 UTC) #2
Nico
On Wed, Jul 9, 2014 at 12:41 PM, <thestig@chromium.org> wrote: > On 2014/07/09 19:33:55, Nico ...
6 years, 5 months ago (2014-07-09 19:43:05 UTC) #3
Lei Zhang
Oh yes, lgtm
6 years, 5 months ago (2014-07-09 19:43:21 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-09 19:44:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/379923008/2
6 years, 5 months ago (2014-07-09 19:45:13 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 19:47:27 UTC) #7
Message was sent while issue was closed.
Change committed as 282100

Powered by Google App Engine
This is Rietveld 408576698