Issue 379923007: Move CONSTANT_POOL_ARRAY_TYPE back into OldPointerSpace type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379923007: Move CONSTANT_POOL_ARRAY_TYPE back into OldPointerSpace type. (Closed)

Created:
6 years, 5 months ago by rmcilroy

Modified:
6 years, 5 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Move CONSTANT_POOL_ARRAY_TYPE back into OldPointerSpace type. r22270 moved CONSTANT_POOL_ARRAY_TYPE out of the OLD_POINTER_SPACE section of the type list and into the OLD_DATA_SPACE section. This means that AllowedToBeMigrated will fail when passed a ConstantPoolArray because the dst == TargetSpaceId(type) check will be false.

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/objects.h	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

6 years, 5 months ago (2014-07-09 17:50:56 UTC) #1

Hannes, could you please take a look.  The change in CONSTANT_POOL_ARRAY_TYPE
causes tests to fail when enabling the out-of-line constant pool on Arm (see
https://codereview.chromium.org/228633002/ which I was trying to land).

Expand Messages | Collapse Messages