Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 379923006: Pull buildtools. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
qsr
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Pull buildtools. This is to get update to checkdeps to update tree walking to not update a list while iterating over it. TBR=qsr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 5 months ago (2014-07-09 17:45:11 UTC) #1
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 5 months ago (2014-07-09 17:45:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/379923006/1
6 years, 5 months ago (2014-07-09 17:47:20 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 21:19:40 UTC) #4
commit-bot: I haz the power
Change committed as 282151
6 years, 5 months ago (2014-07-09 22:41:30 UTC) #5
qsr
6 years, 5 months ago (2014-07-10 11:06:11 UTC) #6
Message was sent while issue was closed.
LGTM. Thanks.

Powered by Google App Engine
This is Rietveld 408576698