tools/perf/measurements/polymer_load.py - Issue 379913002: Update polymer_load to use results.AddValue(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/polymer_load.py

Issue 379913002: Update polymer_load to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/polymer_load.py

diff --git a/tools/perf/measurements/polymer_load.py b/tools/perf/measurements/polymer_load.py

index b8b52c206dd252b628b7b14827b4bc52ab5fbe64..524335bc558a1af0298af9bfc1637adf1e41a3d3 100644

--- a/tools/perf/measurements/polymer_load.py

+++ b/tools/perf/measurements/polymer_load.py

@@ -4,6 +4,7 @@

from telemetry.page import page

from telemetry.page import page_measurement

+from telemetry.value import scalar

class PageForPolymerLoad(page.Page):

@@ -30,4 +31,5 @@ class PageForPolymerLoad(page.Page):

class PolymerLoadMeasurement(page_measurement.PageMeasurement):

def MeasurePage(self, _, tab, results):

result = int(tab.EvaluateJavaScript('__polymer_ready_time'))

- results.Add('Total', 'ms', result)

+ results.AddValue(scalar.ScalarValue(

+ results.current_page, 'Total', 'ms', result))

« no previous file with comments | « no previous file | no next file » | no next file with comments »