Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: test/mjsunit/regress/regress-1170.js

Issue 379893002: Clean up and update const / var (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/global-const-var-conflicts.js ('k') | test/mjsunit/regress/regress-1213575.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --es52_globals
29
30 var setter_value = 0; 28 var setter_value = 0;
31 29
32 this.__defineSetter__("a", function(v) { setter_value = v; }); 30 this.__defineSetter__("a", function(v) { setter_value = v; });
33 eval("var a = 1"); 31 eval("var a = 1");
34 assertEquals(1, setter_value); 32 assertEquals(1, setter_value);
35 assertFalse("value" in Object.getOwnPropertyDescriptor(this, "a")); 33 assertFalse("value" in Object.getOwnPropertyDescriptor(this, "a"));
36 34
37 eval("with({}) { eval('var a = 2') }"); 35 eval("with({}) { eval('var a = 2') }");
36 assertTrue("get" in Object.getOwnPropertyDescriptor(this, "a"));
37 assertFalse("value" in Object.getOwnPropertyDescriptor(this, "a"));
38 assertEquals(2, setter_value); 38 assertEquals(2, setter_value);
39 assertFalse("value" in Object.getOwnPropertyDescriptor(this, "a"));
40 39
41 // Function declarations are treated specially to match Safari. We do 40 // Function declarations are treated specially to match Safari. We do
42 // not call setters for them. 41 // not call setters for them.
43 this.__defineSetter__("a", function(v) { assertUnreachable(); }); 42 this.__defineSetter__("a", function(v) { assertUnreachable(); });
44 eval("function a() {}"); 43 eval("function a() {}");
45 assertTrue("value" in Object.getOwnPropertyDescriptor(this, "a")); 44 assertTrue("value" in Object.getOwnPropertyDescriptor(this, "a"));
46 45
47 this.__defineSetter__("b", function(v) { setter_value = v; }); 46 this.__defineSetter__("b", function(v) { setter_value = v; });
48 try { 47 try {
49 eval("const b = 3"); 48 eval("const b = 3");
50 } catch(e) { 49 } catch(e) { }
51 assertUnreachable(); 50 assertEquals(2, setter_value);
52 }
53 assertEquals(3, setter_value);
54 51
55 try { 52 try {
56 eval("with({}) { eval('const b = 23') }"); 53 eval("with({}) { eval('const b = 23') }");
57 } catch(e) { 54 } catch(e) {
58 assertInstanceof(e, TypeError); 55 assertInstanceof(e, TypeError);
59 } 56 }
60 57
61 this.__defineSetter__("c", function(v) { throw 42; }); 58 this.__defineSetter__("c", function(v) { throw 42; });
62 try { 59 try {
63 eval("var c = 1"); 60 eval("var c = 1");
(...skipping 25 matching lines...) Expand all
89 eval("const dd = 23"); 86 eval("const dd = 23");
90 } catch(e) { 87 } catch(e) {
91 assertUnreachable(); 88 assertUnreachable();
92 } 89 }
93 90
94 try { 91 try {
95 eval("with({}) { eval('const dd = 23') }"); 92 eval("with({}) { eval('const dd = 23') }");
96 } catch(e) { 93 } catch(e) {
97 assertInstanceof(e, TypeError); 94 assertInstanceof(e, TypeError);
98 } 95 }
OLDNEW
« no previous file with comments | « test/mjsunit/global-const-var-conflicts.js ('k') | test/mjsunit/regress/regress-1213575.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698