Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: test/mjsunit/const-eval-init.js

Issue 379893002: Clean up and update const / var (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/mjsunit/const-redecl.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 18 matching lines...) Expand all
29 29
30 // Test the handling of initialization of deleted const variables. 30 // Test the handling of initialization of deleted const variables.
31 // This only makes sense in local scopes since the declaration and 31 // This only makes sense in local scopes since the declaration and
32 // initialization of consts in the global scope happen at the same 32 // initialization of consts in the global scope happen at the same
33 // time. 33 // time.
34 34
35 function testIntroduceGlobal() { 35 function testIntroduceGlobal() {
36 var source = 36 var source =
37 // Deleting 'x' removes the local const property. 37 // Deleting 'x' removes the local const property.
38 "delete x;" + 38 "delete x;" +
39 // Initialization turns into assignment to global 'x'. 39 // Initialization redefines global 'x'.
40 "const x = 3; assertEquals(3, x);" + 40 "const x = 3; assertEquals(3, x);" +
41 // No constness of the global 'x'. 41 // Test constness of the global 'x'.
42 "x = 4; assertEquals(4, x);"; 42 "x = 4; assertEquals(3, x);";
43 eval(source); 43 eval(source);
44 } 44 }
45 45
46 testIntroduceGlobal(); 46 testIntroduceGlobal();
47 assertEquals(4, x); 47 assertEquals("undefined", typeof x);
48 48
49 function testAssignExistingGlobal() { 49 function testAssignExistingGlobal() {
50 var source = 50 var source =
51 // Delete 'x' to remove the local const property. 51 // Delete 'x' to remove the local const property.
52 "delete x;" + 52 "delete x;" +
53 // Initialization turns into assignment to global 'x'. 53 // Initialization redefines global 'x'.
54 "const x = 5; assertEquals(5, x);" + 54 "const x = 5; assertEquals(5, x);" +
55 // No constness of the global 'x'. 55 // Test constness of the global 'x'.
56 "x = 6; assertEquals(6, x);"; 56 "x = 6; assertEquals(5, x);";
57 eval(source); 57 eval(source);
58 } 58 }
59 59
60 testAssignExistingGlobal(); 60 testAssignExistingGlobal();
61 assertEquals(6, x); 61 assertEquals("undefined", typeof x);
62 62
63 function testAssignmentArgument(x) { 63 function testAssignmentArgument(x) {
64 function local() { 64 function local() {
65 var source = "delete x; const x = 7; assertEquals(7, x)"; 65 var source = "delete x; const x = 7; assertEquals(7, x)";
66 eval(source); 66 eval(source);
67 } 67 }
68 local(); 68 local();
69 assertEquals(7, x); 69 assertEquals("undefined", typeof x);
70 } 70 }
71 71
72 for (var i = 0; i < 5; i++) { 72 for (var i = 0; i < 5; i++) {
73 testAssignmentArgument(); 73 testAssignmentArgument();
74 } 74 }
75 %OptimizeFunctionOnNextCall(testAssignmentArgument); 75 %OptimizeFunctionOnNextCall(testAssignmentArgument);
76 testAssignmentArgument(); 76 testAssignmentArgument();
77 assertEquals(6, x); 77 assertEquals("undefined", typeof x);
78 78
79 __defineSetter__('x', function() { throw 42; }); 79 __defineSetter__('x', function() { throw 42; });
80 function testAssignGlobalThrows() { 80 var finished = false;
81 // Initialization turns into assignment to global 'x' which 81 function testRedefineGlobal() {
82 // throws an exception. 82 // Initialization redefines global 'x'.
83 var source = "delete x; const x = 8"; 83 var source = "delete x; const x = 8; finished = true;";
84 eval(source); 84 eval(source);
85 } 85 }
86 86
87 assertThrows("testAssignGlobalThrows()"); 87 testRedefineGlobal();
88 assertTrue(finished);
88 89
89 function testInitFastCaseExtension() { 90 function testInitFastCaseExtension() {
90 var source = "const x = 9; assertEquals(9, x); x = 10; assertEquals(9, x)"; 91 var source = "const x = 9; assertEquals(9, x); x = 10; assertEquals(9, x)";
91 eval(source); 92 eval(source);
92 } 93 }
93 94
94 testInitFastCaseExtension(); 95 testInitFastCaseExtension();
95 96
96 function testInitSlowCaseExtension() { 97 function testInitSlowCaseExtension() {
97 var source = ""; 98 var source = "";
98 // Introduce 100 properties on the context extension object to force 99 // Introduce 100 properties on the context extension object to force
99 // it in slow case. 100 // it in slow case.
100 for (var i = 0; i < 100; i++) source += ("var a" + i + " = " + i + ";"); 101 for (var i = 0; i < 100; i++) source += ("var a" + i + " = " + i + ";");
101 source += "const x = 10; assertEquals(10, x); x = 11; assertEquals(10, x)"; 102 source += "const x = 10; assertEquals(10, x); x = 11; assertEquals(10, x)";
102 eval(source); 103 eval(source);
103 } 104 }
104 105
105 testInitSlowCaseExtension(); 106 testInitSlowCaseExtension();
106 107
107 function testAssignSurroundingContextSlot() { 108 function testAssignSurroundingContextSlot() {
108 var x = 12; 109 var x = 12;
109 function local() { 110 function local() {
110 var source = "delete x; const x = 13; assertEquals(13, x)"; 111 var source = "delete x; const x = 13; assertEquals(13, x)";
111 eval(source); 112 eval(source);
112 } 113 }
113 local(); 114 local();
114 assertEquals(13, x); 115 assertEquals(12, x);
115 } 116 }
116 117
117 testAssignSurroundingContextSlot(); 118 testAssignSurroundingContextSlot();
OLDNEW
« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/mjsunit/const-redecl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698