test/mjsunit/regress/regress-global-freeze-const.js - Issue 379893002: Clean up and update const / var - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(117)

My Issues | Starred Open | Closed | All

Side by Side Diff: test/mjsunit/regress/regress-global-freeze-const.js

Issue 379893002: Clean up and update const / var (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« test/mjsunit/const-redecl.js ('K') | « test/mjsunit/regress/regress-1213575.js ('k') | test/mozilla/mozilla.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 the V8 project authors. All rights reserved.	1 // Copyright 2014 the V8 project authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 __defineSetter__('x', function() { });	5 Object.defineProperty(this, 'x', {set: function() { }});

6 Object.freeze(this);	6 Object.freeze(this);

7 eval('const x = 1');	7 eval('"use strict"; x = 20;');
	rossberg 2014/07/11 12:54:49 Removing the const makes the name of this test obs Removing the const makes the name of this test obscure. Instead, maybe assert that the original eval throws now? Toon Verwaest 2014/07/14 07:39:56 Changed the name of the file to indicate its meani Changed the name of the file to indicate its meaning. I had adjusted the code to ensure it keeps testing what it was supposed to. On 2014/07/11 12:54:49, rossberg wrote: Show quoted text > Removing the const makes the name of this test obscure. Instead, maybe assert > that the original eval throws now? rossberg 2014/07/14 12:04:22 Hm, I think it really was supposed to test const's Show quoted text On 2014/07/14 07:39:56, Toon Verwaest wrote: > Changed the name of the file to indicate its meaning. > I had adjusted the code to ensure it keeps testing what it was supposed to. Hm, I think it really was supposed to test const's behaviour. We changed that behaviour now, so I think it's more adequate to adjust the test expectations rather than to test something different. Or have both.
OLD	NEW

« test/mjsunit/const-redecl.js ('K') | « test/mjsunit/regress/regress-1213575.js ('k') | test/mozilla/mozilla.status » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698