Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 379863002: In iossim, fix default device value for Xcode 6. (Closed)

Created:
6 years, 5 months ago by lliabraa
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

In iossim, fix default device value for Xcode 6. The default was "iPhone", but that's not supported in Xcode 6, so use "iPhone 5" in that case. Also remove an unnecessary call to |connect| when printing supported devices on Xcode 6. This call is not needed and just hangs for a few seconds so remove it (all that's really needed is to load the CoreSimulation framework. BUG=390581 TEST=With Xcode 6 installed, build iossim then run iossim with no optional paramters (e.g. out/Debug-iphonesimulator/iossim path/to/my.app TBR=rohitrao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M testing/iossim/iossim.mm View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lliabraa
6 years, 5 months ago (2014-07-09 14:01:34 UTC) #1
justincohen
awesome, lgtm
6 years, 5 months ago (2014-07-09 14:18:21 UTC) #2
lliabraa
+tbr rohitrao
6 years, 5 months ago (2014-07-09 15:05:42 UTC) #3
lliabraa
The CQ bit was checked by lliabraa@chromium.org
6 years, 5 months ago (2014-07-09 15:05:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/379863002/1
6 years, 5 months ago (2014-07-09 15:06:32 UTC) #5
rohitrao (ping after 24h)
lgtm
6 years, 5 months ago (2014-07-09 15:07:25 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 17:23:47 UTC) #7
Message was sent while issue was closed.
Change committed as 282075

Powered by Google App Engine
This is Rietveld 408576698