tools/perf/measurements/skpicture_printer.py - Issue 379843005: Update skpicture_printer to use results.AddValue(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 379843005: Update skpicture_printer to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/skpicture_printer.py

diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py

index 2bf794047b3fa0787340624a87822f01d6ada5d8..b4dcf4ca135fa7c23c46ab3ea337cb2e28a40c56 100644

--- a/tools/perf/measurements/skpicture_printer.py

+++ b/tools/perf/measurements/skpicture_printer.py

@@ -5,6 +5,7 @@ import glob

import os

from telemetry.page import page_measurement

+from telemetry.value import scalar

_JS = 'chrome.gpuBenchmarking.printToSkPicture("{0}");'

@@ -38,4 +39,5 @@ class SkpicturePrinter(page_measurement.PageMeasurement):

js = _JS.format(outpath.replace('\\', '\\\\'))

tab.EvaluateJavaScript(js)

pictures = glob.glob(os.path.join(outpath, '*.skp'))

- results.Add('saved_picture_count', 'count', len(pictures))

+ results.AddValue(scalar.ScalarValue(

+ results.current_page, 'saved_picture_count', 'count', len(pictures)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »