Issue 379843004: Add target_arch config variable to .isolate files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379843004: Add target_arch config variable to .isolate files. (Closed)

Created:
6 years, 5 months ago by M-A Ruel

Modified:
6 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit), scheib

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add target_arch config variable to .isolate files. Deduplicate chrome.isolate items found in angle.isolate. Move comment about D3DCompiler_43.dll to 32bits build. If it is going to be mapped, it is only for 32 bits builds and not 64 bits builds since this DLL doesn't seem to exist in 64 bits. R=scheib@chromium.org,kbr@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282155

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -5 lines)			Patch
M	build/android/pylib/gtest/setup.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/isolate.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/angle.isolate	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/chrome.isolate	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Whoever wants to review first. This new variable will be used to disambiguate the difference ...

6 years, 5 months ago (2014-07-09 15:32:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/379843004/1

6 years, 5 months ago (2014-07-09 19:07:06 UTC) #5

Message was sent while issue was closed.

Change committed as 282155

Expand Messages | Collapse Messages