Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 379843002: Fixed printing of external references. (Closed)

Created:
6 years, 5 months ago by Sven Panne
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fixed printing of external references. Previously we relied on undefined behavior (printf("%s", NULL)), now we explicitly emit "<unknown>" when we hit an external reference with an unknown name. BUG=392068 LOG=y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/serialize.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 5 months ago (2014-07-09 12:00:21 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 5 months ago (2014-07-09 12:01:14 UTC) #2
Sven Panne
6 years, 5 months ago (2014-07-09 12:12:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698