cc: skipping a horizontal sort by checking the value of vertical_density

cc/resources/picture_pile.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/picture_pile.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 98 matching lines @@
   std::vector<gfx::Rect> invalid_tiles_vertical = invalid_tiles;
   std::sort(invalid_tiles_vertical.begin(),
             invalid_tiles_vertical.end(),
             rect_sort_y);
 
   float vertical_density;
   std::vector<gfx::Rect> vertical_clustering;
   vertical_density = do_clustering(invalid_tiles_vertical,
                                    &vertical_clustering);
 
+  if (vertical_density == 1) {

[vmpstr, 2014/07/09 23:29:11]

nit: 1.f

[hyunki, 2014/07/09 23:43:44]

Done.

+    *record_rects = vertical_clustering;
+    return vertical_density;
+  }
+
   // Now try again with a horizontal sort, see which one is best
-  // TODO(humper): Heuristics for skipping this step?
   std::vector<gfx::Rect> invalid_tiles_horizontal = invalid_tiles;

[vmpstr, 2014/07/09 23:29:11]

Is this used? I think this might have been a typo, but can you fix that while
you're here? And possibly rename invalid_tiles_vertical to something like
invalid_tiles_copy. Either that or use invalid_tiles_horizontal below, whichever
is more efficient.

[hyunki, 2014/07/09 23:43:44]

Sure. I think it is used.
And possibly rename invalid_tiles_vertical to something like
I have changed it to invalid_tiles_horizontal.

Done.

   std::sort(invalid_tiles_vertical.begin(),
             invalid_tiles_vertical.end(),
             rect_sort_x);
 
   float horizontal_density;
   std::vector<gfx::Rect> horizontal_clustering;
   horizontal_density = do_clustering(invalid_tiles_vertical,
                                      &horizontal_clustering);
 
   if (vertical_density < horizontal_density) {
@@ skipping 172 matching lines @@
     }
     DCHECK(found_tile_for_recorded_picture);
   }
 
   has_any_recordings_ = true;
   DCHECK(CanRasterSlowTileCheck(recorded_viewport_));
   return true;
 }
 
 }  // namespace cc