Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 379813004: Always initialize SkDashPathEffect fields. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Always initialize SkDashPathEffect fields. SkDashPathEffect is flattened into a hash key as part of the old-and-busted SkPicture paint deduping code. If all its fields aren't intialized, this hash will be based on uninitialized data. This means the hash won't be deterministic, and worse, Valgrind and MSAN will make us feel bad. An alternative to this is to have SkDashPath::CalcDashParameters always guarantee it writes something to all its output parameters, even when the dash intervals make no sense. I like it being dumb and its users defensive, but could go either way. BUG=391001 Committed: https://skia.googlesource.com/skia/+/1c577cd3ee331944b9061ee0eec147b211ee563c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M src/effects/SkDashPathEffect.cpp View 4 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein_C
6 years, 5 months ago (2014-07-09 16:02:19 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-09 16:19:36 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-09 16:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/379813004/1
6 years, 5 months ago (2014-07-09 16:20:34 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 16:54:23 UTC) #5
Message was sent while issue was closed.
Change committed as 1c577cd3ee331944b9061ee0eec147b211ee563c

Powered by Google App Engine
This is Rietveld 408576698