Issue 379803007: [chromedriver] Rename "emulateViewport" to "mobile".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379803007: [chromedriver] Rename "emulateViewport" to "mobile". (Closed)

Created:
6 years, 5 months ago by samuong

Modified:
6 years, 5 months ago

Reviewers:
stgao

CC:
chromium-reviews, stgao

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[chromedriver] Rename "emulateViewport" to "mobile". BUG=chromedriver:843 TBR=stgao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282089

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -13 lines)			Patch
M	chrome/test/chromedriver/chrome/device_metrics.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/device_metrics.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc	View	2 chunks	+19 lines, -4 lines	1 comment	Download
M	chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc	View	4 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/web_view_impl.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/379803007/1

6 years, 5 months ago (2014-07-09 15:31:14 UTC) #2

stgao

6 years, 5 months ago (2014-07-11 06:00:29 UTC) #4

Message was sent while issue was closed.

lgtm with a nit.

https://codereview.chromium.org/379803007/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc
(right):

https://codereview.chromium.org/379803007/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc:49:
std::string tmp = "mobile";
nit: name |tmp| is not that clear.

Expand Messages | Collapse Messages