Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 379803004: Move UserInfo to user_manager. (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tfarina, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move UserInfo to user_manager. Since user_manager::UserInfo is used on non-chromeos ash implementation, defined part of user_manager component that is included on cross-platform ash. BUG=387614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283087

Patch Set 1 #

Total comments: 4

Patch Set 2 : cleanup user_manager.gypi #

Patch Set 3 : fix gypi #

Patch Set 4 : add EmptyUserInfo #

Patch Set 5 : merge + ash gyp dep #

Patch Set 6 : more deps #

Patch Set 7 : merge + fix views build #

Patch Set 8 : move stub class user_info_impl #

Patch Set 9 : #

Patch Set 10 : cleanup #

Patch Set 11 : #error debug #

Patch Set 12 : remove compiler directove, one more ash dep #

Patch Set 13 : more deps #

Patch Set 14 : ash_unittests dep #

Patch Set 15 : -one dep for ash #

Patch Set 16 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -177 lines) Patch
M ash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +5 lines, -2 lines 0 comments Download
M ash/frame/frame_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/session/session_state_delegate.h View 2 chunks +7 lines, -3 lines 0 comments Download
D ash/session/user_info.h View 1 chunk +0 lines, -45 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 3 4 5 6 7 8 5 chunks +6 lines, -31 lines 0 comments Download
M ash/system/user/accounts_detailed_view.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/user/tray_user_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/user/user_card_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/user/user_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M ash/test/test_session_state_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.cc View 1 2 3 4 5 6 2 chunks +5 lines, -43 lines 0 comments Download
M chrome/browser/ui/views/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -0 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager.gypi View 1 2 3 4 5 6 7 2 chunks +23 lines, -5 lines 0 comments Download
M components/user_manager/DEPS View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A components/user_manager/empty_user_info.h View 1 2 3 4 5 6 7 8 1 chunk +39 lines, -0 lines 0 comments Download
A components/user_manager/empty_user_info.cc View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A + components/user_manager/user_info.h View 1 2 3 4 5 6 7 2 chunks +9 lines, -8 lines 0 comments Download
A + components/user_manager/user_info.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
A components/user_manager/user_info_impl.h View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
A components/user_manager/user_info_impl.cc View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Nikita (slow)
oshima@ - please review whole CL OWNERS: skuhne@: chrome/browser/ui/ash/multi_user/* msw@: chrome/browser/ui/views/* blundell@: components/* So plan ...
6 years, 5 months ago (2014-07-09 11:37:33 UTC) #1
Nikita (slow)
+skuhne@ for chrome/browser/ui/ash/multi_user/*
6 years, 5 months ago (2014-07-09 11:49:51 UTC) #2
blundell
https://codereview.chromium.org/379803004/diff/1/components/user_manager.gypi File components/user_manager.gypi (right): https://codereview.chromium.org/379803004/diff/1/components/user_manager.gypi#newcode14 components/user_manager.gypi:14: 'user_manager/user_manager_export.h', this should be under shared sources, no? https://codereview.chromium.org/379803004/diff/1/components/user_manager.gypi#newcode30 ...
6 years, 5 months ago (2014-07-09 12:23:49 UTC) #3
Nikita (slow)
https://codereview.chromium.org/379803004/diff/1/components/user_manager.gypi File components/user_manager.gypi (right): https://codereview.chromium.org/379803004/diff/1/components/user_manager.gypi#newcode14 components/user_manager.gypi:14: 'user_manager/user_manager_export.h', On 2014/07/09 12:23:49, blundell wrote: > this should ...
6 years, 5 months ago (2014-07-09 12:40:16 UTC) #4
blundell
//components lgtm
6 years, 5 months ago (2014-07-09 12:41:55 UTC) #5
Mr4D (OOO till 08-26)
chrome/browser/ui/ash/multi_user lgtm
6 years, 5 months ago (2014-07-09 14:07:59 UTC) #6
msw
chrome/browser/ui/views/* lgtm
6 years, 5 months ago (2014-07-09 16:59:16 UTC) #7
oshima
lgtm
6 years, 5 months ago (2014-07-09 18:07:27 UTC) #8
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-09 19:10:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/379803004/10001
6 years, 5 months ago (2014-07-09 19:11:58 UTC) #10
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-09 20:10:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/379803004/30001
6 years, 5 months ago (2014-07-09 20:13:00 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 23:27:21 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 00:04:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/36618)
6 years, 5 months ago (2014-07-10 00:04:43 UTC) #15
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-14 18:41:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/379803004/300001
6 years, 5 months ago (2014-07-14 18:42:41 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 23:48:34 UTC) #18
Message was sent while issue was closed.
Change committed as 283087

Powered by Google App Engine
This is Rietveld 408576698