[Blink] Support NumCopies print preset

Support NumCopies print preset

Blink side changes to support NumCopies print preset option.
Copies in print preview dialog should be set to value set for
NumCopies in pdf source document.

BUG=169120
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179042

[Nikhil, 2014-07-09 10:33:39]

_WIP_ patch. Blink side changes required to plumb the value.

[Inactive, 2014-07-15 15:55:00]

https://codereview.chromium.org/379793002/diff/1/Source/web/WebLocalFrameImpl...
File Source/web/WebLocalFrameImpl.cpp (right):

https://codereview.chromium.org/379793002/diff/1/Source/web/WebLocalFrameImpl...
Source/web/WebLocalFrameImpl.cpp:1320: return false;
You should not return a boolean here...

https://codereview.chromium.org/379793002/diff/1/Source/web/WebPluginContaine...
File Source/web/WebPluginContainerImpl.h (right):

https://codereview.chromium.org/379793002/diff/1/Source/web/WebPluginContaine...
Source/web/WebPluginContainerImpl.h:138: int getNumCopies() const;
Ditto about abbreviations.

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h
File public/web/WebFrame.h (right):

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h#newcod...
public/web/WebFrame.h:504: virtual int getNumCopiesForPlugin(const WebNode& =
WebNode()) = 0;
ditto about abbreviations.

https://codereview.chromium.org/379793002/diff/1/public/web/WebPlugin.h
File public/web/WebPlugin.h (right):

https://codereview.chromium.org/379793002/diff/1/public/web/WebPlugin.h#newco...
public/web/WebPlugin.h:118: virtual int getNumCopies() { return 1; }
We usually avoid abbreviations in Blink. getNumberOfCopies()?

[Vitaly Buka (NO REVIEWS), 2014-07-15 21:49:29]

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h
File public/web/WebFrame.h (right):

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h#newcod...
public/web/WebFrame.h:504: virtual int getNumCopiesForPlugin(const WebNode& =
WebNode()) = 0;
maybe also to include "print"?
getPrintCopiesForPlugin

[Nikhil, 2014-07-16 13:58:49]

Review comments incorporated. 

I updated method name in accordance with Chrome side changes at -
https://codereview.chromium.org/375253002/

PTAL, Thanks!

https://codereview.chromium.org/379793002/diff/1/Source/web/WebLocalFrameImpl...
File Source/web/WebLocalFrameImpl.cpp (right):

https://codereview.chromium.org/379793002/diff/1/Source/web/WebLocalFrameImpl...
Source/web/WebLocalFrameImpl.cpp:1320: return false;
On 2014/07/15 15:55:00, Chris Dumez wrote:
> You should not return a boolean here...

Done.

https://codereview.chromium.org/379793002/diff/1/Source/web/WebPluginContaine...
File Source/web/WebPluginContainerImpl.h (right):

https://codereview.chromium.org/379793002/diff/1/Source/web/WebPluginContaine...
Source/web/WebPluginContainerImpl.h:138: int getNumCopies() const;
On 2014/07/15 15:55:00, Chris Dumez wrote:
> Ditto about abbreviations.

Done.

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h
File public/web/WebFrame.h (right):

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h#newcod...
public/web/WebFrame.h:504: virtual int getNumCopiesForPlugin(const WebNode& =
WebNode()) = 0;
On 2014/07/15 15:55:00, Chris Dumez wrote:
> ditto about abbreviations.

Done.

https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h#newcod...
public/web/WebFrame.h:504: virtual int getNumCopiesForPlugin(const WebNode& =
WebNode()) = 0;
On 2014/07/15 21:49:29, Vitaly Buka wrote:
> maybe also to include "print"?
> getPrintCopiesForPlugin

Done.

https://codereview.chromium.org/379793002/diff/1/public/web/WebPlugin.h
File public/web/WebPlugin.h (right):

https://codereview.chromium.org/379793002/diff/1/public/web/WebPlugin.h#newco...
public/web/WebPlugin.h:118: virtual int getNumCopies() { return 1; }
On 2014/07/15 15:55:00, Chris Dumez wrote:
> We usually avoid abbreviations in Blink. getNumberOfCopies()?

Done.

[Nikhil, 2014-07-24 12:11:59]

vitalybuka@, chris@ - <ping!>

Let's try to complete this one now. Related patches have already landed
(https://codereview.chromium.org/345123002/,
https://codereview.chromium.org/388783003/).

PTAL, Thanks!

[Vitaly Buka (NO REVIEWS), 2014-07-25 08:21:45]

lgtm

Why just copies, maybe everything in one CL?

https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginCont...
File Source/web/WebPluginContainerImpl.h (right):

https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginCont...
Source/web/WebPluginContainerImpl.h:137: // Return number of copies to be
printed.
// Return -> Returns

[Nikhil, 2014-07-25 09:44:24]

On 2014/07/25 08:21:45, Vitaly Buka wrote:
> lgtm
> 
> Why just copies, maybe everything in one CL?
> 
>
https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginCont...
> File Source/web/WebPluginContainerImpl.h (right):
> 
>
https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginCont...
> Source/web/WebPluginContainerImpl.h:137: // Return number of copies to be
> printed.
> // Return -> Returns

I'm planning to support one feature fully first (pdfium, Blink, and Chrome
changes). I'll add support for remaining ones together in separate CL. Hope this
is okay.

[Nikhil, 2014-07-25 09:44:44]

https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginCont...
File Source/web/WebPluginContainerImpl.h (right):

https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginCont...
Source/web/WebPluginContainerImpl.h:137: // Return number of copies to be
printed.
On 2014/07/25 08:21:45, Vitaly Buka wrote:
> // Return -> Returns

Done.

[Nikhil, 2014-07-25 09:46:18]

jochen@ - OWNERS review for Blink changes please.

[jochen (gone - plz use gerrit), 2014-07-28 09:42:48]

lgtm

[Nikhil, 2014-07-28 14:39:20]

Rebase patch!

[Nikhil, 2014-07-28 14:39:32]

The CQ bit was checked by n.bansal@samsung.com

[commit-bot: I haz the power, 2014-07-28 14:40:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/n.bansal@samsung.com/379793002/60001

[commit-bot: I haz the power, 2014-07-28 15:47:29]

Change committed as 179042