Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 379793002: [Blink] Support NumCopies print preset (Closed)

Created:
6 years, 5 months ago by Nikhil
Modified:
6 years, 4 months ago
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Support NumCopies print preset Blink side changes to support NumCopies print preset option. Copies in print preview dialog should be set to value set for NumCopies in pdf source document. BUG=169120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179042

Patch Set 1 #

Total comments: 10

Patch Set 2 : Review feedback (update method name) #

Total comments: 2

Patch Set 3 : Review feedback (update comment) #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M Source/web/WebLocalFrameImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/WebFrame.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebPlugin.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Nikhil
_WIP_ patch. Blink side changes required to plumb the value.
6 years, 5 months ago (2014-07-09 10:33:39 UTC) #1
Inactive
https://codereview.chromium.org/379793002/diff/1/Source/web/WebLocalFrameImpl.cpp File Source/web/WebLocalFrameImpl.cpp (right): https://codereview.chromium.org/379793002/diff/1/Source/web/WebLocalFrameImpl.cpp#newcode1320 Source/web/WebLocalFrameImpl.cpp:1320: return false; You should not return a boolean here... ...
6 years, 5 months ago (2014-07-15 15:55:00 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h File public/web/WebFrame.h (right): https://codereview.chromium.org/379793002/diff/1/public/web/WebFrame.h#newcode504 public/web/WebFrame.h:504: virtual int getNumCopiesForPlugin(const WebNode& = WebNode()) = 0; maybe ...
6 years, 5 months ago (2014-07-15 21:49:29 UTC) #3
Nikhil
Review comments incorporated. I updated method name in accordance with Chrome side changes at - ...
6 years, 5 months ago (2014-07-16 13:58:49 UTC) #4
Nikhil
vitalybuka@, chris@ - <ping!> Let's try to complete this one now. Related patches have already ...
6 years, 5 months ago (2014-07-24 12:11:59 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm Why just copies, maybe everything in one CL? https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginContainerImpl.h File Source/web/WebPluginContainerImpl.h (right): https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginContainerImpl.h#newcode137 Source/web/WebPluginContainerImpl.h:137: ...
6 years, 5 months ago (2014-07-25 08:21:45 UTC) #6
Nikhil
On 2014/07/25 08:21:45, Vitaly Buka wrote: > lgtm > > Why just copies, maybe everything ...
6 years, 5 months ago (2014-07-25 09:44:24 UTC) #7
Nikhil
https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginContainerImpl.h File Source/web/WebPluginContainerImpl.h (right): https://codereview.chromium.org/379793002/diff/20001/Source/web/WebPluginContainerImpl.h#newcode137 Source/web/WebPluginContainerImpl.h:137: // Return number of copies to be printed. On ...
6 years, 5 months ago (2014-07-25 09:44:44 UTC) #8
Nikhil
jochen@ - OWNERS review for Blink changes please.
6 years, 5 months ago (2014-07-25 09:46:18 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-28 09:42:48 UTC) #10
Nikhil
Rebase patch!
6 years, 4 months ago (2014-07-28 14:39:20 UTC) #11
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 4 months ago (2014-07-28 14:39:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/379793002/60001
6 years, 4 months ago (2014-07-28 14:40:04 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 15:47:29 UTC) #14
Message was sent while issue was closed.
Change committed as 179042

Powered by Google App Engine
This is Rietveld 408576698