Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 379773003: Simplify the logic in DesktopWindowTreeHostX11 for FocusOut (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
Elliot Glaysher, sadrul, erg
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tfarina, kalyank, ben+aura_chromium.org, ben+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Simplify the logic in DesktopWindowTreeHostX11 for FocusOut We should have the same handling regardless of whether the 'mode' member is NotifyGrab or NotifyUngrab. According to http://tronche.com/gui/x/xlib/events/input-focus/grab.html, whether the mode field is NotifyGrab or NotifyUngrab depends on whether there is a new capturer for the keyboard. The X window has lost keyboard capture in both cases. BUG=392480 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283823

Patch Set 1 : #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M ui/aura/window_event_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
pkotwicz
Elliot, can you please take a look? FocusOut in x11_whole_screen_move_loop.cc should be fixed as well ...
6 years, 5 months ago (2014-07-09 17:35:17 UTC) #1
pkotwicz
I have also checked and this CL does not bring back the bug in https://chromiumcodereview.appspot.com/11189148
6 years, 5 months ago (2014-07-09 17:43:31 UTC) #2
erg
lgtm
6 years, 5 months ago (2014-07-10 20:25:08 UTC) #3
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-10 21:20:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/379773003/60001
6 years, 5 months ago (2014-07-10 21:22:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 23:51:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 23:53:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79274)
6 years, 5 months ago (2014-07-10 23:53:21 UTC) #8
pkotwicz
Sadrul for OWNERS
6 years, 5 months ago (2014-07-11 00:21:10 UTC) #9
pkotwicz
Sadrul for OWNERS for real
6 years, 5 months ago (2014-07-11 00:21:32 UTC) #10
sadrul
cool. LGTM
6 years, 5 months ago (2014-07-15 22:45:49 UTC) #11
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-16 14:56:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/379773003/60001
6 years, 5 months ago (2014-07-16 14:58:19 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 15:02:18 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 15:04:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80256)
6 years, 5 months ago (2014-07-16 15:04:54 UTC) #16
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 14:40:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/379773003/80001
6 years, 5 months ago (2014-07-17 14:40:59 UTC) #18
commit-bot: I haz the power
Change committed as 283823
6 years, 5 months ago (2014-07-17 18:37:36 UTC) #19
pkotwicz
6 years, 5 months ago (2014-07-23 14:04:50 UTC) #20
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/409223003/ by pkotwicz@chromium.org.

The reason for reverting is: I am reverting this CL because it causes
regressions like crbug.com/395985. This CL is in the right direction, but I need
to make the capture code for tab dragging less crazy first. See comment #3 in
crbug.com/395985 for more details.

Powered by Google App Engine
This is Rietveld 408576698