Element table attr border=nonzero & attribute frame=border doesnot consider the border value and fo…

Element table attr border=nonzero & attribute frame=border doesnot consider the border value and for any value draws a thin border.

While applying the frame style for table element CSSPropertyBorderWidth
was being set to CSSValueThin thus showing thing border even if a value
of example 10 was being specified.

We should not set the border width as thin and draw borders as per the
border attribute. Mozilla renders the defined border attribute value.

R=jchaffraix@chromium.org,esprehn@chromium.org,eseidel@chromium.org
BUG=114948

[Gurpreet, 2014-07-09 09:58:54]

Hi. Please review.

[Gurpreet, 2014-07-17 13:48:40]

Hi Julien. Can you please have a look at it?

[Julien - ping for review, 2014-08-05 19:22:43]

We usually recommend the the description to follow the git commit message
format. Thus the first line should be smaller than 80 (I recommend at most 72
based on
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/rqGhY7PfkYY but
git uses an even smaller soft limit).

https://codereview.chromium.org/379763003/diff/1/Source/core/html/HTMLTableEl...
File Source/core/html/HTMLTableElement.cpp (left):

https://codereview.chromium.org/379763003/diff/1/Source/core/html/HTMLTableEl...
Source/core/html/HTMLTableElement.cpp:349:
addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderWidth,
CSSValueThin);
I would rather fix the whole logic to avoid having 2 different passes that are
independent as they are not.

On top of that, you only fix the 'border' and 'box' case but leave the other
valid values inconsistent, which is worse than our current implementation.

[Gurpreet, 2014-08-07 13:48:11]

Hi Julien. Thanks for the review.

I would rather fix the whole logic to avoid having 2 different passes that are
independent as they are not. : You mean getBordersFromFrameAttributeValue is not
required twice?

On top of that, you only fix the 'border' and 'box' case but leave the other
valid values inconsistent, which is worse than our current implementation. :
Border and Box only we need to apply the outsetBorderStyle; for other attribute
values if we apply then all four sides border is shown.

[Gurpreet, 2015-06-22 08:42:06]

Currently not working on this issue. If still reproducible on latest and someone
interested to work can take it up.
Thanks.