Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 379753002: Redo: Adding a mojo interface to the mojo spy (Closed)

Created:
6 years, 5 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Redo: Adding a mojo interface to the mojo spy This is the same as https://codereview.chromium.org/284743002 Which was reverted because a mojo refactoring won the checking race and I did not notice the revert. Original message: Adding more guts to the mojo spy. This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end. Still a quite a few loose ends, specially on teardown. I updated the design doc to reflect this CL: https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing TBR=darin BUG=360188 TEST=manual via test/spy_repl_test.html Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281995

Patch Set 1 #

Patch Set 2 : bindings clash fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -44 lines) Patch
M mojo/mojo.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
A mojo/spy/public/spy.mojom View 1 1 chunk +50 lines, -0 lines 0 comments Download
M mojo/spy/spy.h View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/spy/spy.cc View 6 chunks +43 lines, -22 lines 0 comments Download
A mojo/spy/spy_server_impl.h View 1 chunk +59 lines, -0 lines 0 comments Download
A mojo/spy/spy_server_impl.cc View 1 chunk +91 lines, -0 lines 0 comments Download
M mojo/spy/websocket_server.h View 2 chunks +23 lines, -5 lines 0 comments Download
M mojo/spy/websocket_server.cc View 1 4 chunks +60 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 5 months ago (2014-07-09 04:44:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/379753002/20001
6 years, 5 months ago (2014-07-09 04:46:18 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 07:16:07 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 09:07:47 UTC) #4
Message was sent while issue was closed.
Change committed as 281995

Powered by Google App Engine
This is Rietveld 408576698