Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file.h

Issue 379743003: [fsp] Remove the create flag from the file opening operation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/open_file.h
diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file.h b/chrome/browser/chromeos/file_system_provider/operations/open_file.h
index d0fe1a0f693ee0a5bcbcf0052c32ce6e265c5811..d8494d822cc29dd5a61d66751ae84247d4356f9d 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/open_file.h
+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file.h
@@ -25,16 +25,14 @@ namespace chromeos {
namespace file_system_provider {
namespace operations {
-// Opens a file for either read or write, with optionally creating the file
-// first. Note, that this is part of fileapi::CreateOrOpen file, but it does
-// not download the file locally. Created per request.
+// Opens a file for either read or write. The file must exist, otherwise the
+// operation will fail. Created per request.
class OpenFile : public Operation {
public:
OpenFile(extensions::EventRouter* event_router,
const ProvidedFileSystemInfo& file_system_info,
const base::FilePath& file_path,
ProvidedFileSystemInterface::OpenFileMode mode,
- bool create,
const ProvidedFileSystemInterface::OpenFileCallback& callback);
virtual ~OpenFile();
@@ -50,7 +48,6 @@ class OpenFile : public Operation {
private:
base::FilePath file_path_;
ProvidedFileSystemInterface::OpenFileMode mode_;
- bool create_;
const ProvidedFileSystemInterface::OpenFileCallback callback_;
DISALLOW_COPY_AND_ASSIGN(OpenFile);

Powered by Google App Engine
This is Rietveld 408576698