Update SourceBufferStream and its unit tests to always expect valid durations.

media/base/decoder_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DECODER_BUFFER_H_
 #define MEDIA_BASE_DECODER_BUFFER_H_
 
 #include <string>
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/aligned_memory.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
+#include "media/base/buffers.h"
 #include "media/base/decrypt_config.h"
 #include "media/base/media_export.h"
 
 namespace media {
 
 // A specialized buffer for interfacing with audio / video decoders.
 //
 // Specifically ensures that data is aligned and padded as necessary by the
 // underlying decoding framework.  On desktop platforms this means memory is
 // allocated using FFmpeg with particular alignment and padding requirements.
@@ skipping 43 matching lines @@
   // shave keep as a virtual with hacker_style() for now.
   virtual void set_timestamp(base::TimeDelta timestamp);
 
   base::TimeDelta duration() const {
     DCHECK(!end_of_stream());
     return duration_;
   }
 
   void set_duration(base::TimeDelta duration) {
     DCHECK(!end_of_stream());
+    DCHECK(duration == kNoTimestamp() || duration >= base::TimeDelta())
+        << duration.InSecondsF();

[wolenetz, 2014/07/09 22:42:16]

nit: disallow kInfiniteDuration() buffer duration?

[acolwell GONE FROM CHROMIUM, 2014/07/15 18:49:26]

Done.

     duration_ = duration;
   }
 
   const uint8* data() const {
     DCHECK(!end_of_stream());
     return data_.get();
   }
 
   uint8* writable_data() const {
     DCHECK(!end_of_stream());
@@ skipping 87 matching lines @@
 
   // Constructor helper method for memory allocations.
   void Initialize();
 
   DISALLOW_COPY_AND_ASSIGN(DecoderBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DECODER_BUFFER_H_