Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 379613002: Update octane to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/octane.py
diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py
index c03325222359d72f6c5ffe8660f1241a0917bf0e..6af1bb85afd9555e57798dceb07e70b0776a5320 100644
--- a/tools/perf/benchmarks/octane.py
+++ b/tools/perf/benchmarks/octane.py
@@ -20,8 +20,10 @@ from telemetry.page import page_set
from telemetry.util import statistics
from telemetry.value import scalar
+
_GB = 1024 * 1024 * 1024
+
class _OctaneMeasurement(page_measurement.PageMeasurement):
def __init__(self):
super(_OctaneMeasurement, self).__init__()
@@ -69,7 +71,9 @@ class _OctaneMeasurement(page_measurement.PageMeasurement):
if 'Skipped' not in score_and_name[1]:
name = score_and_name[0]
score = int(score_and_name[1])
- results.Add(name, 'score', score, data_type='unimportant')
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, name, 'score', score, important=False))
+
# Collect all test scores to compute geometric mean.
all_scores.append(score)
total = statistics.GeometricMean(all_scores)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698