Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 379563008: Disable VP9 444 test (Closed)

Created:
6 years, 5 months ago by Johann
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable VP9 444 test The bitstream has changed. Once the roll in https://codereview.chromium.org/380493002 lands this test can be updated and re-enabled. BUG=392309 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281961

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/filters/pipeline_integration_test.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Johann
This test blocks the update to libvpx to correct the bistream.
6 years, 5 months ago (2014-07-08 23:06:54 UTC) #1
Wez
https://codereview.chromium.org/379563008/diff/1/media/filters/pipeline_integration_test.cc File media/filters/pipeline_integration_test.cc (right): https://codereview.chromium.org/379563008/diff/1/media/filters/pipeline_integration_test.cc#newcode1476 media/filters/pipeline_integration_test.cc:1476: TEST_F(PipelineIntegrationTest, Disabled_P444_VP9_WebM) { s/Disabled/DISABLED, and please add a comment ...
6 years, 5 months ago (2014-07-08 23:09:51 UTC) #2
Johann
On 2014/07/08 23:09:51, Wez wrote: > https://codereview.chromium.org/379563008/diff/1/media/filters/pipeline_integration_test.cc > File media/filters/pipeline_integration_test.cc (right): > > https://codereview.chromium.org/379563008/diff/1/media/filters/pipeline_integration_test.cc#newcode1476 > ...
6 years, 5 months ago (2014-07-08 23:31:46 UTC) #3
Wez
LGTM, though you will still need an owner's approval.
6 years, 5 months ago (2014-07-08 23:34:33 UTC) #4
Johann
presubmit suggested vrk@, so adding
6 years, 5 months ago (2014-07-08 23:37:25 UTC) #5
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/379563008/diff/40001/media/filters/pipeline_integration_test.cc File media/filters/pipeline_integration_test.cc (right): https://codereview.chromium.org/379563008/diff/40001/media/filters/pipeline_integration_test.cc#newcode1476 media/filters/pipeline_integration_test.cc:1476: // http://www.crbug.com/392309 can you elaborate this ...
6 years, 5 months ago (2014-07-08 23:58:44 UTC) #6
Johann
The CQ bit was checked by johannkoenig@google.com
6 years, 5 months ago (2014-07-09 00:10:40 UTC) #7
Johann
The CQ bit was unchecked by johannkoenig@google.com
6 years, 5 months ago (2014-07-09 00:12:13 UTC) #8
Johann
The CQ bit was checked by johannkoenig@google.com
6 years, 5 months ago (2014-07-09 00:12:33 UTC) #9
Johann
On 2014/07/09 00:12:13, Johann wrote: > The CQ bit was unchecked by mailto:johannkoenig@google.com Woops, I ...
6 years, 5 months ago (2014-07-09 00:12:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johannkoenig@google.com/379563008/80001
6 years, 5 months ago (2014-07-09 00:15:08 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 05:43:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 281961

Powered by Google App Engine
This is Rietveld 408576698