Issue 379563006: Merge 281089 "Include the latest binary download info in safe br..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379563006: Merge 281089 "Include the latest binary download info in safe br..." (Closed)

Created:
6 years, 5 months ago by grt (UTC plus 2)

Modified:
6 years, 5 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge 281089 "Include the latest binary download info in safe br..." > Include the latest binary download info in safe browsing incident reports. > > BUG=383042 > > Review URL: https://codereview.chromium.org/330653006 TBR=grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281833

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+413 lines, -105 lines)			Patch
M	chrome/browser/safe_browsing/download_protection_service.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	chrome/browser/safe_browsing/incident_report_uploader.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/incident_reporting_service.h	View	7 chunks	+47 lines, -12 lines	0 comments	Download
M	chrome/browser/safe_browsing/incident_reporting_service.cc	View	14 chunks	+122 lines, -26 lines	0 comments	Download
M	chrome/browser/safe_browsing/incident_reporting_service_unittest.cc	View	21 chunks	+186 lines, -43 lines	0 comments	Download
A +	chrome/browser/safe_browsing/last_download_finder.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/safe_browsing/last_download_finder.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/safe_browsing/last_download_finder_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/safe_browsing/download_protection_util.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/common/safe_browsing/download_protection_util.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	4 chunks	+31 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r281833.

Expand Messages | Collapse Messages