gm/rebaseline_server/imagediffdb.py - Issue 379563005: rebaseline_server: cache results in long-running ImageDiffDB instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/imagediffdb.py

Issue 379563005: rebaseline_server: cache results in long-running ImageDiffDB instance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/imagediffdb.py

diff --git a/gm/rebaseline_server/imagediffdb.py b/gm/rebaseline_server/imagediffdb.py

index 985017af1c28b862525957588df4e8482ca10541..be4f8c17fa4fa7cc0667a8b3256b0a49c33cbe4f 100644

--- a/gm/rebaseline_server/imagediffdb.py

+++ b/gm/rebaseline_server/imagediffdb.py

@@ -221,6 +221,9 @@ class ImageDiffDB(object):

# actual_image_locator) tuples.

self._diff_dict = {}

+ def get_storage_root(self):

rmistry 2014/07/09 13:14:04 [Optional] Can also do: @property def storage_roo

epoger 2014/07/09 14:57:36 Good point. Fixed this one, and added a TODO for

+ return self._storage_root

def add_image_pair(self,

expected_image_url, expected_image_locator,

actual_image_url, actual_image_locator):

« no previous file with comments | « gm/rebaseline_server/compare_to_expectations_test.py ('k') | gm/rebaseline_server/server.py » ('j') | no next file with comments »