Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 379563003: Convert blink_perf.py to use results.AddValue(..) (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert blink_perf.py to use results.AddValue(..) BUG=391943 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/perf/benchmarks/blink_perf.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nednguyen
6 years, 5 months ago (2014-07-08 17:53:08 UTC) #1
eakuefner
lgtm, caveat: I'm not a full reviewer yet so I'd recommend having dtu or tonyg ...
6 years, 5 months ago (2014-07-08 18:25:49 UTC) #2
nednguyen
On 2014/07/08 18:25:49, eakuefner wrote: > lgtm, caveat: I'm not a full reviewer yet so ...
6 years, 5 months ago (2014-07-08 19:11:36 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-08 19:11:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/379563003/1
6 years, 5 months ago (2014-07-08 19:12:25 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 23:51:13 UTC) #6
Message was sent while issue was closed. 
Change committed as 281890

Powered by Google App Engine
This is Rietveld 408576698