Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 379563002: Fix issues with code serializer. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
vogelheim
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix issues with code serializer. - code pre-aging does not work with serializing. - compilation info needs to remember that we compile for serializing. - test case leaks memory. R=vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/compiler.h View 4 chunks +16 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-08 11:19:09 UTC) #1
vogelheim
lgtm
6 years, 5 months ago (2014-07-08 11:42:29 UTC) #2
Yang
6 years, 5 months ago (2014-07-08 14:13:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698