Change g_native_tls_key to be 32-bit wide to match underlying type.

Change g_native_tls_key to be 32-bit wide to match underlying type.

BUG=392037
TEST=base_unittests --gtest_filter=ThreadLocalStorageTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281691

[Nico, 2014-07-08 04:32:10]

lgtm

[Will Harris, 2014-07-08 04:38:23]

The CQ bit was checked by wfh@chromium.org

[michaelbai, 2014-07-08 04:39:37]

This was wrong, the key is int in posix, it will be 64 bits in 64-bit OS.

[commit-bot: I haz the power, 2014-07-08 04:39:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wfh@chromium.org/379503002/1

[Will Harris, 2014-07-08 04:42:43]

On 2014/07/08 04:39:37, michaelbai wrote:
> This was wrong, the key is int in posix, it will be 64 bits in 64-bit OS.

pthread_key_t is unsigned int which is always 32-bit

include/bits/pthread_types.h

/* Keys for thread-specific data */
typedef unsigned int pthread_key_t;

I'm not sure which part you think is 'wrong'?

[Nico, 2014-07-08 04:52:56]

On 2014/07/08 04:39:37, michaelbai wrote:
> This was wrong, the key is int in posix, it will be 64 bits in 64-bit OS.

I think Windows uses LLP64 and Linux uses LP64 (
http://en.wikipedia.org/wiki/64-bit_computing#64-bit_data_models ); in both
models ints are 32bit on 64 bit as far as I know.

(On Windows, longs are 32bit too)

[commit-bot: I haz the power, 2014-07-08 05:49:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-08 07:37:09]

Change committed as 281691

[michaelbai, 2014-07-08 16:21:35]

On 2014/07/08 04:52:56, Nico (away) wrote:
> On 2014/07/08 04:39:37, michaelbai wrote:
> > This was wrong, the key is int in posix, it will be 64 bits in 64-bit OS.
> 
> I think Windows uses LLP64 and Linux uses LP64 (
> http://en.wikipedia.org/wiki/64-bit_computing#64-bit_data_models ); in both
> models ints are 32bit on 64 bit as far as I know.
> 
> (On Windows, longs are 32bit too)

Thanks, I were thinking int will be 64 bit in some 64 bits system.