Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 379493002: X87: More OStreamsUse OStreams more often (Closed)

Created:
6 years, 5 months ago by chunyang.dai
Modified:
6 years, 5 months ago
Reviewers:
Weiliang, Sven Panne
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: More OStreamsUse OStreams more often port r22232 original commit message: This is a mostly mechanical CL (more than 90% Emacs macros and query-replace-regexp) moving FILE*/StringStream*-based APIs to OStream-based APIs. There are a few places where this had to stop, otherwise the CL would be even bigger, but this can easily and incrementally cleaned up later. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/x87/lithium-x87.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-x87.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
weiliang. please review this patch. thanks.
6 years, 5 months ago (2014-07-08 04:38:47 UTC) #1
Weiliang
lgtm
6 years, 5 months ago (2014-07-08 05:16:44 UTC) #2
Weiliang
6 years, 5 months ago (2014-07-08 05:26:46 UTC) #3
Committed as r22259

Powered by Google App Engine
This is Rietveld 408576698