chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h - Issue 379483003: Fix use-after-free in BrowserActionOverflowMenuController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

Issue 379483003: Fix use-after-free in BrowserActionOverflowMenuController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc » ('j') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

index 6203c79a5fd8df5f8aeb7b568462b8f86afe016b..5edf73019176a39db25b5dc7b3e734b198aaa8d8 100644

--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

@@ -51,6 +51,9 @@ class BrowserActionOverflowMenuController : public views::MenuDelegate {

// Closes the overflow menu (and its context menu if open as well).

void CancelMenu();

+ // Notify the menu that the associated BrowserActionViews have been deleted.

+ void NotifyBrowserActionViewsDeleting();

// Overridden from views::MenuDelegate:

virtual bool IsCommandEnabled(int id) const OVERRIDE;

virtual void ExecuteCommand(int id) OVERRIDE;