Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 379473002: Rename composited selection anchor/focus to start/end (Closed)

Created:
6 years, 5 months ago by jdduke (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename composited selection anchor/focus to start/end Maintain naming consistency with Blink wherein selection start and end indicate proper and consistent ordering in the document. BUG=279489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283421

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -73 lines) Patch
M cc/output/compositor_frame_metadata.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +22 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M content/common/cc_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jdduke (slow)
tsepez@: Security review for content/common/cc_messages.h (sorry for the noise!). jam@: Trivial owner review for content/renderer.
6 years, 5 months ago (2014-07-08 00:50:25 UTC) #1
Tom Sepez
Rubberstamp LGTM on renaming members.
6 years, 5 months ago (2014-07-08 17:44:31 UTC) #2
jdduke (slow)
Yay, forgot to add owners in my original publish. PTAL for trivial OWNER review: jam@: ...
6 years, 5 months ago (2014-07-10 21:00:07 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 5 months ago (2014-07-11 00:07:21 UTC) #4
jam
lgtm
6 years, 5 months ago (2014-07-15 00:14:51 UTC) #5
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 5 months ago (2014-07-15 00:36:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/379473002/20001
6 years, 5 months ago (2014-07-15 00:44:04 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 16:46:38 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 17:58:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/38942)
6 years, 5 months ago (2014-07-15 17:58:32 UTC) #10
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 5 months ago (2014-07-16 15:40:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/379473002/20001
6 years, 5 months ago (2014-07-16 15:44:56 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 17:54:46 UTC) #13
Message was sent while issue was closed. 
Change committed as 283421

Powered by Google App Engine
This is Rietveld 408576698