Issue 379463002: Display property as specified on svg elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379463002: Display property as specified on svg elements. (Closed)

Created:
6 years, 5 months ago by rune

Modified:
6 years, 5 months ago

Reviewers:
pdr., fs

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, andersr

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Display property as specified on svg elements. The computed display of svg elements should be as for other elements. For svg:svg elements, they should behave as other replaced elements when styled with inline-block, table-cell, etc. For svg elements inside the root svg element, they still get a computed value for display as other elements, although the rendering is the same for all display values different from 'none'. This change aligns the behavior with that of Gecko. This change makes it possible to remove the custom style building for display. R=pdr@chromium.org,fs@opera.com BUG=391959 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177649

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -24 lines)			Patch
A	LayoutTests/svg/css/display.html	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/css/display-computed.html	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/css/display-expected.html	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSProperties.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/379463002/1

6 years, 5 months ago (2014-07-08 07:42:01 UTC) #4

Message was sent while issue was closed.

Change committed as 177649

Expand Messages | Collapse Messages