Change ownership of video file

tools/telemetry/telemetry/core/video.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import subprocess
+import tempfile
 
 from telemetry.core import bitmap
 from telemetry.core import platform
 from telemetry.page import cloud_storage
 
 HIGHLIGHT_ORANGE_FRAME = bitmap.WEB_PAGE_TEST_ORANGE
 
 class BoundingBoxNotFoundException(Exception):
   pass
 
 
 class Video(object):
   """Utilities for storing and interacting with the video capture."""
 
-  def __init__(self, video_file_path):
-    # TODO(satyanarayana): Figure out when to delete this file.
-    self._video_file_path = video_file_path
+  def __init__(self, video_file_obj):
+    assert isinstance(video_file_obj, tempfile.NamedTemporaryFile)

[nednguyen, 2014/07/08 23:24:20]

You may also want to assert that video_file_obj.close_called is False.

[Satyanarayana N H Manyam, 2014/07/09 00:58:02]

class name here (tempfile._TemporaryFileWrapper) is not public, so using delete
attribute of this object as a proxy for this.

[Satyanarayana N H Manyam, 2014/07/09 00:58:02]

Done.

+    self._video_file_obj = video_file_obj
     self._tab_contents_bounding_box = None
 
   def UploadToCloudStorage(self, bucket, target_path):
     """Uploads video file to cloud storage.
 
     Args:
       target_path: Path indicating where to store the file in cloud storage.
     """
-    cloud_storage.Insert(bucket, target_path, self._video_file_path)
+    cloud_storage.Insert(bucket, target_path, self._video_file_obj.name)
 
   def GetVideoFrameIter(self):
     """Returns the iteration for processing the video capture.
 
     This looks for the initial color flash in the first frame to establish the
     tab content boundaries and then omits all frames displaying the flash.
 
     Yields:
       (time_ms, bitmap) tuples representing each video keyframe. Only the first
       frame in a run of sequential duplicate bitmaps is typically included.
         time_ms is milliseconds since navigationStart.
         bitmap is a telemetry.core.Bitmap.
     """
-    frame_generator = self._FramesFromMp4(self._video_file_path)
+    frame_generator = self._FramesFromMp4(self._video_file_obj.name)
 
     # Flip through frames until we find the initial tab contents flash.
     content_box = None
     for _, bmp in frame_generator:
       content_box = self._FindHighlightBoundingBox(
           bmp, HIGHLIGHT_ORANGE_FRAME)
       if content_box:
         break
 
     if not content_box:
@@ skipping 103 matching lines @@
                              'rawvideo', '-pix_fmt', 'rgb24', '-dump',
                              '-loglevel', 'debug', '-f', 'rawvideo', '-'],
                             stderr=subprocess.PIPE, stdout=subprocess.PIPE)
     while True:
       num_read = proc.stdout.readinto(frame_data)
       if not num_read:
         raise StopIteration
       assert num_read == len(frame_data), 'Unexpected frame size: %d' % num_read
       yield (GetFrameTimestampMs(proc.stderr),
              bitmap.Bitmap(3, dimensions[0], dimensions[1], frame_data))