Change ownership of video file

build/android/pylib/screenshot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import tempfile
 
 from pylib import cmd_helper
 
 # TODO(jbudorick) Remove once telemetry gets switched over.
 import pylib.android_commands
 import pylib.device.device_utils
 
 
 class VideoRecorder(object):
   """Records a screen capture video from an Android Device (KitKat or newer).
 
   Args:
     device: DeviceUtils instance.
     host_file: Path to the video file to store on the host.
     megabits_per_second: Video bitrate in megabits per second. Allowed range
                          from 0.1 to 100 mbps.
     size: Video frame size tuple (width, height) or None to use the device
           default.
     rotate: If True, the video will be rotated 90 degrees.
   """
-  def __init__(self, device, host_file, megabits_per_second=4, size=None,
+  def __init__(self, device, megabits_per_second=4, size=None,
                rotate=False):

[nednguyen, 2014/07/08 22:28:12]

There are other place that specifies the host_file param. You need to keep that
param, either in the constructor or make it a param of the Pull(..) method.

[nduca, 2014/07/08 22:34:21]

or update the other callsites to use the new pull model

[Satyanarayana N H Manyam, 2014/07/08 22:46:41]

Ok added the parameter to the Pull then.

     # TODO(jbudorick) Remove once telemetry gets switched over.
     if isinstance(device, pylib.android_commands.AndroidCommands):
       device = pylib.device.device_utils.DeviceUtils(device)
     self._device = device
     self._device_file = (
         '%s/screen-recording.mp4' % device.GetExternalStoragePath())
-    self._host_file = host_file or ('screen-recording-%s.mp4' %
-                                    device.old_interface.GetTimestamp())
-    self._host_file = os.path.abspath(self._host_file)
     self._recorder = None
     self._recorder_pids = None
     self._recorder_stdout = None
     self._is_started = False
 
     self._args = ['adb']
     if self._device.old_interface.GetDevice():
       self._args += ['-s', self._device.old_interface.GetDevice()]
     self._args += ['shell', 'screenrecord', '--verbose']
     self._args += ['--bit-rate', str(megabits_per_second * 1000 * 1000)]
     if size:
       self._args += ['--size', '%dx%d' % size]
     if rotate:
       self._args += ['--rotate']
     self._args += [self._device_file]
 
   def Start(self):
     """Start recording video."""
-    self._device.old_interface.EnsureHostDirectory(self._host_file)
     self._recorder_stdout = tempfile.mkstemp()[1]
     self._recorder = cmd_helper.Popen(
         self._args, stdout=open(self._recorder_stdout, 'w'))
     self._recorder_pids = self._device.old_interface.ExtractPid('screenrecord')
     if not self._recorder_pids:
       raise RuntimeError('Recording failed. Is your device running Android '
                          'KitKat or later?')
 
   def IsStarted(self):
     if not self._is_started:
@@ skipping 10 matching lines @@
     if not self._recorder or not self._recorder_pids:
       return
     self._device.RunShellCommand(
         'kill -SIGINT ' + ' '.join(self._recorder_pids))
     self._recorder.wait()
 
   def Pull(self):
     """Pull resulting video file from the device.
 
     Returns:
-      Output video file name on the host.
+      Output video file object on the host.

[nduca, 2014/07/08 22:34:21]

NamedTemporaryFile containing the video, on the host

[Satyanarayana N H Manyam, 2014/07/08 22:57:27]

Updated the code a bit

     """
+    host_file_obj = tempfile.NamedTemporaryFile(
+        suffix='screen-recording-%s.mp4' % (
+            self._device.old_interface.GetTimestamp()))
     self._device.old_interface.PullFileFromDevice(
-        self._device_file, self._host_file)
+        self._device_file, host_file_obj.name)
     self._device.RunShellCommand('rm -f "%s"' % self._device_file)
-    return self._host_file
+    return host_file_obj