Issue 379413002: Turn on clang by default on linux, 3rd try.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379413002: Turn on clang by default on linux, 3rd try. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
awong1

CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Turn on clang by default on linux, 3rd try. This is mostly to collect performance and size data for now, and to find out if more bots need work. Unless things look really good, I'm going to revert this by thursday morning (PDT). BUG=360311 TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	build/common.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tools/clang/scripts/update.sh	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Committed patchset #1 manually as r282246 (presubmit successful).

6 years, 5 months ago (2014-07-10 03:55:29 UTC) #2

horo

6 years, 5 months ago (2014-07-10 07:24:59 UTC) #3

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/378363006/ by horo@chromium.org.

The reason for reverting is: NaClBrowserTestNonSfiMode.Messaging and
NaClBrowserTestNonSfiMode.Irt failed.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/1212...
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/1212....

Expand Messages | Collapse Messages