Refactor WebCrypto code

content/child/webcrypto/algorithm_registry.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_CHILD_WEBCRYPTO_JWK_H_
-#define CONTENT_CHILD_WEBCRYPTO_JWK_H_
+#ifndef CONTENT_CHILD_WEBCRYPTO_ALGORITHM_REGISTRY_H_
+#define CONTENT_CHILD_WEBCRYPTO_ALGORITHM_REGISTRY_H_
 
-#include <vector>
-
-#include "base/basictypes.h"
-#include "third_party/WebKit/public/platform/WebArrayBuffer.h"
 #include "third_party/WebKit/public/platform/WebCrypto.h"
-#include "third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h"
 
 namespace content {
 
 namespace webcrypto {
 
-class CryptoData;
+class AlgorithmImplementation;
 class Status;
 
-Status ImportKeyJwk(const CryptoData& key_data,
-                    const blink::WebCryptoAlgorithm& algorithm,
-                    bool extractable,
-                    blink::WebCryptoKeyUsageMask usage_mask,
-                    blink::WebCryptoKey* key);
-
-Status ExportKeyJwk(const blink::WebCryptoKey& key, std::vector<uint8>* buffer);
+Status GetAlgorithmFromRegistry(blink::WebCryptoAlgorithmId id,
+                                const AlgorithmImplementation** impl);

[Ryan Sleevi, 2014/07/10 23:20:54]

This leaves me unclear what the lifetime semantics are for
AlgorithmImplementations

[eroman, 2014/07/11 00:27:36]

The AlgorithmImplementations are threadsafe singletons that are constructed on
the first webcrypto operation. They only contain const methods and are glorified
vtables.

I will see if there is a clearer way to indicate this. One possibility is to
remove algorithm_registry.{h,cc} and move the singleton as an implementation
detail of algorithm_dispatch.cc.

 
 }  // namespace webcrypto
 
 }  // namespace content
 
-#endif  // CONTENT_CHILD_WEBCRYPTO_JWK_H_
+#endif  // CONTENT_CHILD_WEBCRYPTO_ALGORITHM_REGISTRY_H_