Implement Evaluate without creating new classes.

runtime/vm/debugger_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "platform/assert.h"
 #include "vm/dart_api_impl.h"
 #include "vm/thread.h"
 #include "vm/unit_test.h"
@@ skipping 1972 matching lines @@
   EXPECT_VALID(len);
   EXPECT(Dart_IsNumber(len));
   EXPECT_EQ(6, ToInt64(len));
 
   Dart_Handle error =
       Dart_EvaluateExpr(script_lib, NewString("new NonexistingType()"));
   EXPECT(Dart_IsError(error));
 }
 
 
+static void EvaluateInActivationOfEvaluateHandler(Dart_IsolateId isolate_id,
+                                                  Dart_Handle exception_object,
+                                                  Dart_StackTrace trace) {
+  breakpoint_hit_counter++;
+  Dart_ActivationFrame top_frame = 0;
+  Dart_Handle result = Dart_GetActivationFrame(trace, 0, &top_frame);
+  EXPECT_VALID(result);
+
+  result = Dart_ActivationFrameEvaluate(top_frame, NewString("p.r"));
+  EXPECT_VALID(result);
+  EXPECT_EQ(5.0, ToDouble(result));
+}
+
+
+TEST_CASE(Debug_EvaluateInActivationOfEvaluate) {
+  // This library deliberately declares no top-level variables or methods.

[hausner, 2014/07/10 22:57:26]

Maybe add a sentence why that is significant?

[rmacnak, 2014/07/10 23:17:37]

Added.

+  const char* kScriptChars =
+      "import 'dart:math';               \n"
+      "class Point {                     \n"
+      "  var x, y;                       \n"
+      "  Point(this.x, this.y);          \n"
+      "  get r => sqrt(x*x + y*y);       \n"
+    "}                                 \n";

[hausner, 2014/07/10 22:57:26]

Nit: alignment.

+  LoadScript(kScriptChars);
+  Dart_FinalizeLoading();

[hausner, 2014/07/10 22:57:26]

Why not moving the FinalizeLoading call into the helper function LoadScript()?

[rmacnak, 2014/07/10 23:17:37]

Some tests fail, mostly related to snapshots.

+
+  Dart_SetExceptionThrownHandler(&EvaluateInActivationOfEvaluateHandler);
+  Dart_SetExceptionPauseInfo(kPauseOnAllExceptions);
+  breakpoint_hit_counter = 0;
+
+  Dart_Handle result = Dart_EvaluateExpr(script_lib, NewString(
+      "() { var p = new Point(3, 4); throw p; } ())"));
+  EXPECT(Dart_IsError(result));
+  EXPECT_EQ(1, breakpoint_hit_counter);
+}
+
+
 TEST_CASE(Debug_GetClosureInfo) {
   const char* kScriptChars =
       "void foo() { return 43; } \n"
       "                          \n"
       "main() {                  \n"
       "  return foo;             \n"
       "}                         \n";
 
   LoadScript(kScriptChars);
   Dart_Handle clo = Invoke("main");
@@ skipping 218 matching lines @@
       " null, 3, 7, 1, 8, 6, 9, 10, 10, 11, 11, 13,"
       " null, 4, 13, 3, 14, 10,"
       " null, 5, 17, 5, 18, 9, 19, 12,"
       " null, 6, 21, 1,"
       " null, 8, 24, 1, 25, 5, 26, 6, 27, 8,"
       " null, 9, 29, 1]",
       tokens_cstr);
 }
 
 }  // namespace dart