Issue 379323003: Temporary disables 2 tests in service_worker_browsertest.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379323003: Temporary disables 2 tests in service_worker_browsertest.cc. (Closed)

Created:
6 years, 5 months ago by horo

Modified:
6 years, 5 months ago

Reviewers:
falken

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org, Yuta Kitamura

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Temporary disables 2 tests in service_worker_browsertest.cc. These tests will be broken by the blink side change which removes HeaderMap and introduces Headers class. https://codereview.chromium.org/373613004/ After the blink side change will land, I will re-enable the tests. BUG=373120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282309

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	content/browser/service_worker/service_worker_browsertest.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	content/test/data/service_worker/fetch_event.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/data/service_worker/fetch_event_reload.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/379323003/1

6 years, 5 months ago (2014-07-10 06:36:32 UTC) #4

Message was sent while issue was closed.

Change committed as 282309

Expand Messages | Collapse Messages