chrome/browser/net/connection_tester.cc - Issue 379293002: Add AssertNoURLRequests() to URLRequestContext subclass destructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/connection_tester.cc

Issue 379293002: Add AssertNoURLRequests() to URLRequestContext subclass destructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to two omitted subclasses of subclasses of URLRequestContext. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/connection_tester.cc

diff --git a/chrome/browser/net/connection_tester.cc b/chrome/browser/net/connection_tester.cc

index 37c5aeac54d87e2a4d3abe1fc593855fb3b98b41..f93e863baf53a4596343bb9ec47f4726a0fbf265 100644

--- a/chrome/browser/net/connection_tester.cc

+++ b/chrome/browser/net/connection_tester.cc

@@ -59,7 +59,9 @@ class ExperimentURLRequestContext : public net::URLRequestContext {

storage_(this),

weak_factory_(this) {}

- virtual ~ExperimentURLRequestContext() {}

+ virtual ~ExperimentURLRequestContext() {

+ AssertNoURLRequests();

+ }

// Creates a proxy config service for |experiment|. On success returns net::OK

// and fills |config_service| with a new pointer. Otherwise returns a network