chrome/browser/ui/views/passwords/manage_passwords_view_test.cc - Issue 379283002: Rework UMAHistogramHelper and StatisticsDeltaReader into [Chrome]HistogramTester.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

Issue 379283002: Rework UMAHistogramHelper and StatisticsDeltaReader into [Chrome]HistogramTester. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_view_test.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc b/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

index da4401e7c871f09288fa3769810bf44cbbbbd33f..618217de520510c6ccc86c386b15b35146ef6a3d 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

@@ -4,7 +4,6 @@

#include "chrome/browser/ui/views/passwords/manage_passwords_view_test.h"

-#include "base/test/statistics_delta_reader.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_command_controller.h"

@@ -104,6 +103,6 @@ base::HistogramSamples* ManagePasswordsViewTest::GetSamples(

const char* histogram) {

// Ensure that everything has been properly recorded before pulling samples.

content::RunAllPendingInMessageLoop();

- return statistics_reader_.GetHistogramSamplesSinceCreation(

- histogram).release();

+ return histogram_tester_.GetHistogramSamplesSinceCreation(histogram)

+ .release();

}