chrome/browser/ui/views/passwords/manage_passwords_view_test.cc - Issue 379283002: Rework UMAHistogramHelper and StatisticsDeltaReader into [Chrome]HistogramTester.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

Issue 379283002: Rework UMAHistogramHelper and StatisticsDeltaReader into [Chrome]HistogramTester. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Prefer base histogram_tester. ChromeHistogramTester with RunMessageLoop for NaCl Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_view_test.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc » ('j') | chrome/renderer/net/net_error_helper_core_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc b/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

index b1f8f44969adb30cf9ac57f8c97748d582858a58..ef3f6810fdf707d1d5e401475c3d75780a2216e7 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

@@ -4,7 +4,7 @@

#include "chrome/browser/ui/views/passwords/manage_passwords_view_test.h"

-#include "base/test/statistics_delta_reader.h"

+#include "base/test/histogram_tester.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_command_controller.h"

@@ -90,6 +90,6 @@ base::HistogramSamples* ManagePasswordsViewTest::GetSamples(

const char* histogram) {

// Ensure that everything has been properly recorded before pulling samples.

content::RunAllPendingInMessageLoop();

- return statistics_reader_.GetHistogramSamplesSinceCreation(

+ return histogram_tester_.GetBaseHistogramSamples(

histogram).release();

Ilya Sherman 2014/07/15 03:56:35 nit: Please rewrap this line (probably wise to run

Mike Lerman 2014/07/16 17:29:03 Done.

}