Chromium Code Reviews| Index: Source/platform/graphics/ImageBufferSurface.h |
| diff --git a/Source/platform/graphics/ImageBufferSurface.h b/Source/platform/graphics/ImageBufferSurface.h |
| index 58edfc546f24e437ef135265ad2e7567672ada0f..1eddd4571398f9486d8fdba6d3504eadd5bc647f 100644 |
| --- a/Source/platform/graphics/ImageBufferSurface.h |
| +++ b/Source/platform/graphics/ImageBufferSurface.h |
| @@ -36,9 +36,11 @@ |
| #include "platform/graphics/GraphicsTypes3D.h" |
| #include "wtf/FastAllocBase.h" |
| #include "wtf/Noncopyable.h" |
| +#include "wtf/PassRefPtr.h" |
| -class SkCanvas; |
| class SkBitmap; |
| +class SkCanvas; |
| +class SkPicture; |
| namespace blink { class WebLayer; } |
| @@ -54,10 +56,10 @@ enum OpacityMode { |
| class PLATFORM_EXPORT ImageBufferSurface { |
| WTF_MAKE_NONCOPYABLE(ImageBufferSurface); WTF_MAKE_FAST_ALLOCATED; |
| public: |
| - virtual ~ImageBufferSurface() { } |
| + virtual ~ImageBufferSurface(); |
| virtual SkCanvas* canvas() const = 0; |
| - virtual const SkBitmap& bitmap() const; |
| + virtual const SkBitmap& bitmap(); |
| virtual void willUse() { } // Called by ImageBuffer before reading or writing to the surface. |
| virtual void willReadback() { } |
| virtual bool isValid() const = 0; |
| @@ -71,6 +73,8 @@ public: |
| virtual void updateCachedBitmapIfNeeded() { } |
| virtual void setIsHidden(bool) { } |
| virtual void setImageBuffer(ImageBuffer*) { } |
| + virtual PassRefPtr<SkPicture> getPicture(); |
|
Stephen White
2014/07/09 20:04:07
Nit: all the other "{ return 0; }" virtuals above
Justin Novosad
2014/07/11 21:16:07
The reason it is not inline is that returning a Pa
Stephen White
2014/07/14 15:19:15
Acknowledged.
|
| + virtual void didClearCanvas() { } |
| OpacityMode opacityMode() const { return m_opacityMode; } |
| const IntSize& size() const { return m_size; } |