Initial implementation of display list backed 2D canvases

Source/platform/graphics/ImageBufferSurface.cpp

Index: Source/platform/graphics/ImageBufferSurface.cpp
diff --git a/Source/platform/graphics/ImageBufferSurface.cpp b/Source/platform/graphics/ImageBufferSurface.cpp
index 2869f4cc29ae5a05d3d2daffbcf23b52930bd775..1d1971021de1b41baf742b284725f362237590f9 100644
--- a/Source/platform/graphics/ImageBufferSurface.cpp
+++ b/Source/platform/graphics/ImageBufferSurface.cpp
@@ -35,6 +35,7 @@
 #include "platform/graphics/ImageBuffer.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkDevice.h"
+#include "third_party/skia/include/core/SkPicture.h"
 
 namespace WebCore {
 
@@ -45,6 +46,14 @@ ImageBufferSurface::ImageBufferSurface(const IntSize& size, OpacityMode opacityM
     setIsHidden(false);
 }
 
+ImageBufferSurface::~ImageBufferSurface()
+{ }
+
+PassRefPtr<SkPicture> ImageBufferSurface::getPicture()
+{
+    return nullptr;
+}
+
 void ImageBufferSurface::clear()
 {
     // Clear the background transparent or opaque, as required. It would be nice if this wasn't
@@ -55,12 +64,13 @@ void ImageBufferSurface::clear()
             canvas()->drawARGB(255, 0, 0, 0, SkXfermode::kSrc_Mode);
         else
             canvas()->drawARGB(0, 0, 0, 0, SkXfermode::kClear_Mode);
+        didClearCanvas();
     }
 }
 
-const SkBitmap& ImageBufferSurface::bitmap() const
+const SkBitmap& ImageBufferSurface::bitmap()
 {
-    ASSERT(canvas());

[Sergey, 2014/07/21 04:57:10]

This is probably a newbie comment, but still, why would you delete this ASSERT?

[Justin Novosad, 2014/07/21 17:26:46]

That is a good question while writing this patch, at some point, the code was in
a state where canvas() could return a null pointer.  That is no longer the case
with the current implementation, so I should put it back.  Thanks for noticing.

+    willReadback();
     return canvas()->getTopDevice()->accessBitmap(false);
 }